Peter van Munster wrote:
Great work, José!
First impressions are pretty good, using the new version in my small trial eSpace.
Remarks:
- the component references an eSpace BPL_Theme, which I don't have. It doesn't seem to bother the implementation, so maybe it can just be cleared from the component.
- the Helper functions are great, but why not use the same input parameters (aside from the MessageType) as are being used with the FeedbackMessage action?
- maybe the ManualClose parameter can be added to the FeedbackMessage action?
- you might consider using site properties to set some default values for Timeout, HideAnimation (so they can be used by the Helper functions as well) and ManualClose, although the last one should probably have a simple False as default as a parameter.
When I have more time, I will try to run some more tests.
Regards, Peter
Hi Peter,
Tanks a lot for the feedback.
That reference is now removed from the version 2.0.1, I forgot to clear all unused stuff from the espace before uploading it.
Actually the helpers I confess I did them just because the seemed to be handy to me like that, but I agree, I might just apply the same input set as in the other feedback and leave it with default behaviour.
Regarding animations
This is also something I changed in the component, if you look into the Feedback_Message_Proxy webblock you will find the following javascript functions in the JS sections of the webblock:
- animateFeedback (element, animation)
- Function that defines each animation behaviour in jQueryanimation ;
- hideFeedback (timeout,animationName)
- Function that defines the way it calculates the time for hiding the feedback;
Now this two functions are global scope functions. You can even use the animateFeedback as a standalone animation to hide some elements in your applications.
That said in terms of animations you can always wrap around this webblock and overwrite them to meet any special need or desire for your projects.
If you find the correct jquery animation to display in the cases it is not working that great please share with us and I'm happy to incorporate better behaviour in this component.
Regards,
José