Hi,
At our company we are looking to upgrade to ArdoJSON 1.11.0 (from 1.10.1) and have noticed that the action DEPRECATED_JSON_GetAttributes returns nothing.
I've taken a look at the extension code, and this action is simply not implemented!
A bit futher down in the code the old implementation still seems to be in there though:
This makes upgrading to the new version a problem for anyone using this JSON_GetAttributes action.
Can you please fix this?
Kind regards,
Steven
Dear
in the summary they have mentioned you need to use new function JSON_objectify
I am aware of this.We can use JSON_Listify and JSON_Deserialize as an alternative to JSON_GetAttributes.That is not the issue.
The issue is that deprecating an action should mean that the action is still functional, but should be avoided for new development as it will probably be deleted in a future version of ArdoJSON.
Removing the implementation is clearly a bug. You either delete the action or you deprecate it (keeping the implementation).
I'm pretty sure that this is an unintended consequence of renaming the existing action.
JSON_Objectify has been deprecated correctly for example. The old, deprecated, action still exists and still works as before, while the new version was created alongside of it.
I agree, "deprecated" generally means "this method still functions, but you shouldn't use it because it will be going away soon"The whole point of deprecating a function is to not break backwards compatibility, while informing users to update their code so it doesn't use this method.containing a non-working method is pointless, because it still breaks backwards compatibility.
Hi Steven,
Thanks for bringing this to attention. I'll see if I can fix it.
I published version 1.11.1 that should fix the problem. Can you check whether it works now?