20
Views
2
Comments
[Feature Toggle Management] Feature Toggle permission issue when specifying Team
feature-toggle-management
Reactive icon
Forge asset by Experts
Application Type
Reactive

Hello,

There is issue with Feature Toggle switch permissions when specifying team to a feature toggle.

When specifying Team to a Feature Toggle only one environment toggle switch is active, rest environments switches are inactive for a team member.

I tried to analyze the LifetimeTeams_Sync_ServiceAccount action logic and found following:

 1. The only one record is inserted in LifetimeTeamUser user with first environment appeared in the list, remaining environments are missing because once GetUsersByUsername aggregate returns a result no more records will be inserted for user. The logic should check both, for the user and environment. So, the GetUsersByUsername must filter by user and environment. 

2. HasChangePermissions is not updated for the existing users. If the team member role changed, so HasChangePermissions has new value, the change will not be updated in LifetimeTeamUser. There must be update part in the logic to fix this.

3. If by some reason user is not found at all (e.g. there might be inactive users), new record will be inserted to LifetimeTeamUser with UserId equal to 0. The logic must check if the user is found in the User table.

We have 'EnableLifetimeServiceAccount' set to 'True' so I have looked only to the Sync logic with 'ServiceAccount'.

Hope this helps.

Will be waiting for the new version with fixes.

Thanks.

Mikheil Osipov


FT Toggle Switch Permission Issue.png
2018-11-06 13-59-01
Mark Horenberg

When will there be a fix for this issue. We would like to use the teams feature to separate feature toggles per team, since we have quite a lot toggles over our applications. For now we can do without, but it would be nice to have a time frame on when this issue will be fixed.

2018-01-05 02-53-30
Grayson Udstrand

I am surprised this has not been fixed yet - if you are running the timer that routinely syncs lifetime teams (which runs every 15 minutes by default) then you also generate millions of bad records where UserId = 0. Eventually the result of this is the queries related to syncing this data permanently locking the Team and TeamUser tables. Once that happens, your only recourse is to trunc the TeamUser table and restart the countdown to the next time you'll have to do this. Strongly recommend the team looks into fixing this issue in the next release.

Community GuidelinesBe kind and respectful, give credit to the original source of content, and search for duplicates before posting.