Hello,

The Server Actions inside the loop are also doing a for each with the same list?

Hi João Pedro Espinheira, 

You are using var1 for Start index, means if it is a number default value will be 0.

After each iteration var1 value should be increased so it will iterate for all records. Make sure var1 is increasing as var1 = var1 + 1 after if condition for True and False branch. 

Regards,

Shubham

Hi João,

I'm not sure where that error message comes from, as I don't see any obvious recursive loops. Can it be that one of the Actions inside the For Each loop has the full list as input, and tries to iterate over the list?

That said, the restart logic of your Timer is flawed. What happens when the loop is finished (20 records have been processed), is that:

1. You adjust var1;
2. You try to restart the Timer;
3. You execute the query again;
4. You restart the loop again, in the same Timer.

First, restarting a Timer doesn't do anything while the Timer is still running. Check my article here on the gritty details. The only thing that'll happen is that when the Timer is finished, it will restart. But... your Timer never finishes, until all records have been processed.

Secondly, you execute the query each iteration. This is typically not what you want, as if the data changes, you'll process different records, and may even reprocess certain records, depending on the criteria in the Aggregate.

Thirdly, why do you process only 20 records, if you are going to process all records anyway (since the Timer won't stop until Var1 (very bad name btw!) has a value greater than the number of records in the query result.

Fourthly, why do you limit the number of records in the For Each, instead of in the Aggregate? Unless you adhere to a number of specific limitations, you will transfer way more data from the database server than you need, which is slow.

So what did you intend to do, functionally? Process only 20 records, then restart the Timer, then process the next 20? (Btw, Timers can conveniently run for large stretches of time, the processing must be really slow to warrent only 20 records, 1000 records is more typical.) Note that you cannot set Var1 and then expect it to keep its value between Timer runs - each Timer run is fully independent of the previous one!

What you would typically want is this:

• Query only the limited set you want to process. Make sure that the query does not select records you already processed (e.g. by left-joining an Entity that only gets filled when processing, or by keeping track of a processing status per record, etc.);
• After processing the records in the For Each (don't use a Start Index or Maximum Iterations, that's not needed if you design your query correctly), check whether the number of records the Aggregate returns against the Max. Records you specified - if it's less, you know everything's been processed and you can End the Timer, otherwise call the Timer's Wake action, then End the action.

That's it. The Timer will restart itself, query a fresh set of records, process them, etc. until there's nothing more to query.

i m adjusting var, when i wake up timer isnt that suposed to save the last data? i checked and none of my server actions have a for each inside. they do have agregates with sum values

I noticed Killian already gave a good explanation but I would like to visualize it a bit more to make it more clear. 

• I see you wake the timer again after you have finished a batch of records. Why do you do that? The current action will not end because the next action is the aggregate again. This will schedule the timer to run after the current action/timer is stopped and that will then have nothing to do since you already processed everything.
  
• You have an exit based on a validation of what I presume a check if the current record is the last record? Why not let the for each handle that? That is what it is for.
  
• You don't follow the best practice's for a Timer. This should include a timeout prevention capability but most important of all a Commit Transaction (or delete record) to make sure that if you rerun the timer you don't reprocess already processed data.
  Please look at the Timer masterclass course that will go into detail about this. You will also notice that the flow will be different and that the timer restart will be the last widget at one of the end nodes.
• The starting index variable should not be needed in your case. I don't see any method to set this value so the value is 0. Make things more clear by not using variables that don't get a value set. You fellow developers will thank you later on.
• Edit: One last thing. Here you probably update the "IsProcessed" property of the record but nowhere are you updating this change to the database. All other actions are Ifs and could possible follow the false line and therefor not be handled at all.
  
• Edit 2: Why are you checking if the current record is already processed? This should be included in you aggregate so you don't even get those records at all. This will simplify your logic and you will have a smaller memory food print.

Hello João Pedro Espinheira,

I can see your timer has infinite loop, as soon as your foreach loop ends, you are again redirecting to aggregate and that will output a list which will iterate in loop again so it will never ends.

You should check some condition if want to process remaining records(In this case also there should be a flag in entity which you need to update in any server action post process.

another thing will be, you dont need to again call aggregate after WakeTimer action, that aggregate will never execute. Waketimer will simply re-execute your server action from Start node.

for the resolution of my problem, was changing the list i was passing to an object, i was passing the list of the for each to the action instead of the current.

Still i m finding quite usefull this topic so, Vincent Koning do you suggest another aproach?